fix(cli-config): add parameters for elevation preview urls BM-1407#3554
Closed
tawera-manaena wants to merge 2 commits into
Closed
fix(cli-config): add parameters for elevation preview urls BM-1407#3554tawera-manaena wants to merge 2 commits into
tawera-manaena wants to merge 2 commits into
Conversation
tawera-manaena
had a problem deploying
to
preprod
GitHub Actions
Failure
tawera-manaena
had a problem deploying
to
preprod
GitHub Actions
Failure
tawera-manaena
temporarily deployed
to
preprod
GitHub Actions
Inactive
tawera-manaena
temporarily deployed
to
preprod
GitHub Actions
Inactive
tawera-manaena
temporarily deployed
to
preprod
GitHub Actions
Inactive
blacha
reviewed
Nov 4, 2025
| tag: `${PublicUrlBase}@${center.location.lat},${center.location.lon},z${center.location.zoom}?config=${configPath}&p=${tileMatrix.identifier}&debug`, | ||
| }; | ||
|
|
||
| if (configImagery.category?.toLowerCase() === 'elevation') { |
Member
There was a problem hiding this comment.
I don't think we can rely on the category for determining what pipeline we should use.
Some elevation datasets I believe are not terrain-rgb datasets, there are also other datasets that will need the pipeline parameter. some of these will also have more than one output pipeline that may need to be referenced.
Contributor
Author
There was a problem hiding this comment.
Hmm, good to know. Let me think on this for a moment.
Contributor
Author
|
Will close this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our basemaps-config preview URLs for Elevation inserts no longer show anything in Basemaps. Example here.
You can't see the imagery until you add the following parameters to such URLs:
We need to update our cli-config package's
importcommand to add thepipelineandformatparameters automatically.Modifications
packages/cli-config/src/cli/
action.import.tsUpdated the
prepareUrlfunction so that the following key-value pairs are appended to URLs forelevationcategory imagery:Verification
I attempted to introduce a unit test - but abandoned it as I had issues faking the
BasemapsConfigProvidermem parameter required to call theprepareURLfunction.Instead, I ran the
importcommand locally and inspected the URLs produced in the generated markdown:Individual Inserts
thames-2017-2019-dsm-1m
christchurch-urban-2020-2021-0.075m